Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const stabilize mem::discriminant #103893

Closed
wants to merge 1 commit into from
Closed

Const stabilize mem::discriminant #103893

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2022

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 2, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ghost
Copy link
Author

ghost commented Nov 2, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 2, 2022
@inquisitivecrystal inquisitivecrystal added relnotes Marks issues that should be documented in the release notes of the next release. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2022
@bors
Copy link
Contributor

bors commented Nov 14, 2022

☔ The latest upstream changes (presumably #103858) made this pull request unmergeable. Please resolve the merge conflicts.

@joshtriplett
Copy link
Member

Sorry for the long delay in reviewing this. LGTM, r=me with the merge conflicts fixed.

@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Sep 27, 2023
@dtolnay dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2023
@dtolnay dtolnay mentioned this pull request Sep 27, 2023
Closed
3 tasks
@ghost ghost closed this by deleting the head repository Sep 28, 2023
@dtolnay dtolnay mentioned this pull request Sep 28, 2023
Merged
@dtolnay
Copy link
Member

dtolnay commented Sep 28, 2023

I've rebased this PR as #116240.

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2023
@bors
Auto merge of rust-lang#116240 - dtolnay:constdiscriminant, r=thomcc
06f9d37 
Const stabilize mem::discriminant

Tracking issue: rust-lang#69821.

This PR is a rebase of rust-lang#103893 to resolve conflicts in library/core/src/lib.rs (against rust-lang#102470 and rust-lang#110393).
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2023
@bors
Auto merge of rust-lang#116240 - dtolnay:constdiscriminant, r=thomcc
7cc36de 
Const stabilize mem::discriminant

Tracking issue: rust-lang#69821.

This PR is a rebase of rust-lang#103893 to resolve conflicts in library/core/src/lib.rs (against rust-lang#102470 and rust-lang#110393).
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 2, 2023
@bors
Auto merge of #116240 - dtolnay:constdiscriminant, r=thomcc
6923412 
Const stabilize mem::discriminant

Tracking issue: #69821.

This PR is a rebase of rust-lang/rust#103893 to resolve conflicts in library/core/src/lib.rs (against #102470 and #110393).
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
@bors
Auto merge of #116240 - dtolnay:constdiscriminant, r=thomcc
b54b31c 
Const stabilize mem::discriminant

Tracking issue: #69821.

This PR is a rebase of rust-lang/rust#103893 to resolve conflicts in library/core/src/lib.rs (against #102470 and #110393).
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #116240 - dtolnay:constdiscriminant, r=thomcc
f0fddb3 
Const stabilize mem::discriminant

Tracking issue: #69821.

This PR is a rebase of rust-lang/rust#103893 to resolve conflicts in library/core/src/lib.rs (against #102470 and #110393).
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for const mem::discriminant
5 participants
@rustbot @bors @joshtriplett @dtolnay @inquisitivecrystal